LLM/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-05-22 20:05:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(desktop-wsl): drop DefaultUid=0 first-run gate, --user root bypasses OOBE

Browse Source 
Verified with live probes: 'wsl -d Ubuntu-24.04 --user root -- echo OK' succeeds on a distro whose registry DefaultUid is still 0 (OOBE never ran). The prior hang symptom was from invoking wsl WITHOUT --user when DefaultUid=0, which triggers the interactive 'Create a default UNIX user account' prompt. With --user root explicit in wslArgs the OOBE hook is skipped and resolveWslOpencode finds /root/.opencode/bin/opencode etc. Remove the overly aggressive first-run gate from spawnWslSidecar; the registry probe helpers stay in wsl.ts for future diagnostic use. 20s timeout + failure logging remain as safety nets for true wsl.exe wedges.
This commit is contained in:
LukeParkerDev
2026-04-17 15:49:38 +10:00
parent 3822c0aaec
commit f347d9a58a
1 changed files with 10 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
packages/desktop-electron/src/main/server.ts
View File

@@ -5,7 +5,7 @@ import { app } from "electron"
import { DEFAULT_SERVER_URL_KEY } from "./constants"
import { getUserShell, loadShellEnv } from "./shell-env"
import { getStore } from "./store"
import { checkWslDistroFirstRun, type WslCommandLine, resolveWslOpencode, wslArgs } from "./wsl"
import { type WslCommandLine, resolveWslOpencode, wslArgs } from "./wsl"
export type HealthCheck = { wait: Promise<void> }
@@ -83,23 +83,15 @@ export async function spawnWslSidecar(
distro: string,
opts: { onLine?: (line: WslCommandLine) => void; healthTimeoutMs?: number } = {},
): Promise<WslSidecar> {
// Gate on the registry state BEFORE any wsl.exe invocation. If the
// distro still has DefaultUid=0 it means the interactive first-run
// "Create a default UNIX user account" prompt never completed, and
// every wsl.exe -d <distro> ... call will silently block on stdin
// forever (we verified: Ubuntu-24.04 hangs on both -- echo and
// --user root -- echo in this state). Fail fast with a clear message
// so the controller can surface it to the user.
const firstRun = await checkWslDistroFirstRun(distro)
if (firstRun.status === "not-installed") {
throw new Error(`WSL distro ${distro} is not installed`)
}
if (firstRun.status === "needs-first-run") {
throw new Error(
`WSL distro ${distro} has not completed first-run setup. Open a terminal and run 'wsl -d ${distro}' to create a default UNIX user, then retry.`,
)
}
// Every wsl.exe invocation below goes through wslArgs which injects
// `--user root`. That matters even when a distro has DefaultUid=0
// (i.e. the interactive first-run user account setup never ran):
// explicit --user root bypasses the OOBE hook that would otherwise
// prompt on stdin, so we can resolve opencode and spawn the sidecar
// without any machine-wide first-run handshake. The earlier Ubuntu
// hang was caused by invoking without --user (default uid 0 triggers
// OOBE), not by the registry state itself. We still have a 20s
// timeout in runCommand as a safety net for true wsl.exe wedges.
const opencode = await resolveWslOpencode(distro)
if (!opencode) throw new Error(`OpenCode is not installed in ${distro}`)