LLM/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-05-21 19:35:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(server): drop unused Ref in listener stop

Browse Source 
The forceRequested Ref + trailing re-yield of forceCloseOnce only forced
graceful stops to wait for a concurrent force-close's WebSocketTracker
cleanup. The scope close already triggers closeAllConnections via the
serverRef.forceStop flag, so all callers observe the same end state
without it.
This commit is contained in:
Kit Langton
2026-05-14 19:19:52 -04:00
parent d3684d7a59
commit e3aba59d06
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/opencode/src/server/server.ts
View File

@@ -1,6 +1,6 @@
import { NodeHttpServer } from "@effect/platform-node"
import * as Log from "@opencode-ai/core/util/log"
import { ConfigProvider, Context, Effect, Exit, Layer, Ref, Scope } from "effect"
import { ConfigProvider, Context, Effect, Exit, Layer, Scope } from "effect"
import { HttpRouter, HttpServer } from "effect/unstable/http"
import { OpenApi } from "effect/unstable/httpapi"
import { createServer } from "node:http"
@@ -173,17 +173,14 @@ function setupMdns(opts: ListenOptions, port: number, scope: Scope.Scope) {
function makeStop(state: ListenerState, unpublishMdns: Effect.Effect<void>) {
return Effect.gen(function* () {
const forceRequested = yield* Ref.make(false)
const forceCloseOnce = yield* Effect.cached(forceClose(state).pipe(Effect.ignore))
const closeScopeOnce = yield* Effect.cached(Scope.close(state.scope, Exit.void).pipe(Effect.ignore))
return (close?: boolean) =>
Effect.gen(function* () {
if (close) yield* Ref.set(forceRequested, true)
yield* unpublishMdns
if (close) yield* forceCloseOnce
yield* closeScopeOnce
if (yield* Ref.get(forceRequested)) yield* forceCloseOnce
})
})
}