diff --git a/packages/opencode/test/config/config.test.ts b/packages/opencode/test/config/config.test.ts index ccc63d807d..9a88fcf4b9 100644 --- a/packages/opencode/test/config/config.test.ts +++ b/packages/opencode/test/config/config.test.ts @@ -1204,67 +1204,37 @@ test("keeps plugin origins aligned with merged plugin list", async () => { // Legacy tools migration tests -test("migrates legacy tools config to permissions - allow", async () => { - await using tmp = await tmpdir({ - init: async (dir) => { - await Filesystem.write( - path.join(dir, "opencode.json"), - JSON.stringify({ - $schema: "https://opencode.ai/config.json", - agent: { - test: { - tools: { - bash: true, - read: true, - }, - }, - }, - }), - ) - }, - }) - await withTestInstance({ - directory: tmp.path, - fn: async (ctx) => { - const config = await load(ctx) - expect(config.agent?.["test"]?.permission).toEqual({ - bash: "allow", - read: "allow", - }) - }, - }) -}) +it.instance("migrates legacy tools config to permissions - allow", () => + Effect.gen(function* () { + const test = yield* TestInstance + yield* writeConfigEffect(test.directory, { + $schema: "https://opencode.ai/config.json", + agent: { test: { tools: { bash: true, read: true } } }, + }) -test("migrates legacy tools config to permissions - deny", async () => { - await using tmp = await tmpdir({ - init: async (dir) => { - await Filesystem.write( - path.join(dir, "opencode.json"), - JSON.stringify({ - $schema: "https://opencode.ai/config.json", - agent: { - test: { - tools: { - bash: false, - webfetch: false, - }, - }, - }, - }), - ) - }, - }) - await withTestInstance({ - directory: tmp.path, - fn: async (ctx) => { - const config = await load(ctx) - expect(config.agent?.["test"]?.permission).toEqual({ - bash: "deny", - webfetch: "deny", - }) - }, - }) -}) + const config = yield* Config.Service.use((svc) => svc.get()) + expect(config.agent?.["test"]?.permission).toEqual({ + bash: "allow", + read: "allow", + }) + }), +) + +it.instance("migrates legacy tools config to permissions - deny", () => + Effect.gen(function* () { + const test = yield* TestInstance + yield* writeConfigEffect(test.directory, { + $schema: "https://opencode.ai/config.json", + agent: { test: { tools: { bash: false, webfetch: false } } }, + }) + + const config = yield* Config.Service.use((svc) => svc.get()) + expect(config.agent?.["test"]?.permission).toEqual({ + bash: "deny", + webfetch: "deny", + }) + }), +) it.instance("migrates legacy write tool to edit permission", () => Effect.gen(function* () { diff --git a/perf/test-suite.md b/perf/test-suite.md index b37b868bbd..77f7e7359b 100644 --- a/perf/test-suite.md +++ b/perf/test-suite.md @@ -81,6 +81,7 @@ Repeated setup work, long sleeps/timeouts, serial integration tests, filesystem/ | Managed settings config cases can use Effect-aware instance fixtures | Migrated managed override and missing-managed-file cases to `it.instance` | 2.40s | 1.76s | keep | Single baseline before edit; after median from three sequential reruns (1.75, 1.76, 1.80). | | Local plugin and subagent config fixtures can use Effect-aware instance fixtures | Migrated scoped npm plugin and custom subagent markdown cases to `it.instance` | 2.37s | 1.67s | keep | Single baseline before edit; after median from three sequential reruns (1.66, 1.67, 1.67). | | MCP merge config cases can use Effect-aware instance fixtures | Migrated three MCP merge/override cases to `it.instance` | 1.98s | 1.95s | keep | Neutral timing within noise; removes manual `tmpdir` + `withTestInstance` setup from isolated filesystem-only config cases. | +| Remaining legacy tools config cases can use Effect-aware instance fixtures | Migrated allow/deny legacy `tools` permission cases to `it.instance` | 2.65s | 1.90s | keep | Single baseline before edit; after median from three sequential reruns (2.58, 1.90, 1.90). | ## Profiling Results