From 0b81258a81d373ca4f886f8ff30fcfb9dbc82369 Mon Sep 17 00:00:00 2001
From: vimtor <vn4varro@gmail.com>
Date: Tue, 19 May 2026 11:51:53 +0200
Subject: [PATCH] core: tell Go users why referrals and rewards fail

---
 .../console/app/src/component/go-referral.tsx |  4 +-
 packages/console/core/src/referral.ts         | 39 +++++++------------
 2 files changed, 16 insertions(+), 27 deletions(-)

diff --git a/packages/console/app/src/component/go-referral.tsx b/packages/console/app/src/component/go-referral.tsx
index bd93b6560a..6a186974ea 100644
--- a/packages/console/app/src/component/go-referral.tsx
+++ b/packages/console/app/src/component/go-referral.tsx
@@ -154,8 +154,8 @@ export function GoReferralSection(props: { workspaceID: string; summary: GoRefer
   async function onApply() {
     const reward = selected()
     if (!reward) return
-    const result = await apply(props.workspaceID, reward.id)
-    if (result.applied) setSelected(undefined)
+    await apply(props.workspaceID, reward.id)
+    setSelected(undefined)
   }
 
   return (
diff --git a/packages/console/core/src/referral.ts b/packages/console/core/src/referral.ts
index 3d49ae1425..7150a21bdc 100644
--- a/packages/console/core/src/referral.ts
+++ b/packages/console/core/src/referral.ts
@@ -181,7 +181,7 @@ export namespace Referral {
         )
         .then((rows) => rows[0])
       if (!reward) throw new Error("Referral reward not found")
-      if (reward.timeApplied) return { applied: false }
+      if (reward.timeApplied) throw new Error("Referral reward already applied")
 
       const update = await tx
         .update(ReferralRewardTable)
@@ -196,11 +196,11 @@ export namespace Referral {
             isNull(ReferralRewardTable.timeDeleted),
           ),
         )
-      if (update.rowsAffected === 0) return { applied: false }
+      if (update.rowsAffected === 0) throw new Error("Referral reward already applied")
 
       await Billing.subtractLiteUsage(workspaceID, reward.amount)
 
-      return { applied: true, amount: microCentsToCents(reward.amount) }
+      return { amount: microCentsToCents(reward.amount) }
     })
   })
 
@@ -282,7 +282,7 @@ export namespace Referral {
     referralCode?: string
   }) {
     const referralCode = normalizeCode(input.referralCode)
-    if (!referralCode) return { status: "missing-code" as const }
+    if (!referralCode) return
 
     return Database.transaction(async (tx) => {
       const code = await tx
@@ -290,14 +290,14 @@ export namespace Referral {
         .from(WorkspaceTable)
         .where(and(eq(WorkspaceTable.referralCode, referralCode), isNull(WorkspaceTable.timeDeleted)))
         .then((rows) => rows[0])
-      if (!code) return { status: "invalid-code" as const }
+      if (!code) throw new Error("Referral code invalid")
 
       const existingReferral = await tx
         .select({ id: ReferralTable.id })
         .from(ReferralTable)
         .where(and(eq(ReferralTable.inviteeAccountID, input.accountID), isNull(ReferralTable.timeDeleted)))
         .then((rows) => rows[0])
-      if (existingReferral) return { status: "already-redeemed" as const }
+      if (existingReferral) throw new Error("Referral already redeemed")
 
       const selfReferral = await tx
         .select({ id: UserTable.id })
@@ -310,31 +310,25 @@ export namespace Referral {
           ),
         )
         .then((rows) => rows[0])
-      if (selfReferral) return { status: "self-referral" as const }
+      if (selfReferral) throw new Error("Self-referral is not allowed")
 
       const referralID = Identifier.create("referral")
       await tx
         .insert(ReferralTable)
+        .ignore()
         .values({
           workspaceID: code.workspaceID,
           id: referralID,
           inviteeAccountID: input.accountID,
         })
-        .onDuplicateKeyUpdate({
-          set: {
-            inviteeAccountID: sql`${ReferralTable.inviteeAccountID}`,
-          },
-        })
 
       const referral = await tx
         .select({ id: ReferralTable.id, workspaceID: ReferralTable.workspaceID })
         .from(ReferralTable)
         .where(and(eq(ReferralTable.inviteeAccountID, input.accountID), isNull(ReferralTable.timeDeleted)))
         .then((rows) => rows[0])
-      if (!referral) return { status: "duplicate" as const }
-      if (referral.id !== referralID) return { status: "already-redeemed" as const }
-
-      return { status: "created" as const }
+      if (!referral) throw new Error("Referral not created")
+      if (referral.id !== referralID) throw new Error("Referral already redeemed")
     })
   }
 
@@ -350,17 +344,18 @@ export namespace Referral {
           and(eq(UserTable.workspaceID, input.workspaceID), eq(UserTable.id, input.userID), isNull(UserTable.timeDeleted)),
         )
         .then((rows) => rows[0])
-      if (!invitee?.accountID) return { status: "missing-account" as const }
+      if (!invitee?.accountID) throw new Error("Referral invitee account missing")
 
       const referral = await tx
         .select({ id: ReferralTable.id, workspaceID: ReferralTable.workspaceID })
         .from(ReferralTable)
         .where(and(eq(ReferralTable.inviteeAccountID, invitee.accountID), isNull(ReferralTable.timeDeleted)))
         .then((rows) => rows[0])
-      if (!referral) return { status: "missing-referral" as const }
+      if (!referral) throw new Error("Referral not found")
 
       const result = await tx
         .insert(ReferralRewardTable)
+        .ignore()
         .values([
           {
             workspaceID: referral.workspaceID,
@@ -373,14 +368,8 @@ export namespace Referral {
             amount: REWARD_AMOUNT,
           },
         ])
-        .onDuplicateKeyUpdate({
-          set: {
-            amount: sql`${ReferralRewardTable.amount}`,
-          },
-        })
 
-      if (result.rowsAffected === 0) return { status: "already-completed" as const }
-      return { status: "created" as const }
+      if (result.rowsAffected === 0) throw new Error("Referral already completed")
     })
   }