From 693c775a7ff97af1737c2cf7e59fa9710840acb2 Mon Sep 17 00:00:00 2001 From: Shakker Date: Tue, 12 May 2026 21:42:45 +0100 Subject: [PATCH] test: tag provider unit assertions --- extensions/google/speech-provider.test.ts | 5 +++-- extensions/openai/realtime-voice-provider.test.ts | 2 +- extensions/skill-workshop/index.test.ts | 2 +- extensions/voice-call/index.test.ts | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/extensions/google/speech-provider.test.ts b/extensions/google/speech-provider.test.ts index 8f40f4a3d7f..4ffa8b0038b 100644 --- a/extensions/google/speech-provider.test.ts +++ b/extensions/google/speech-provider.test.ts @@ -578,8 +578,9 @@ describe("Google speech provider", () => { const provider = buildGoogleSpeechProvider(); const voices = await provider.listVoices?.({ providerConfig: {} }); - expect(voices?.some((voice) => voice.id === "Kore" && voice.name === "Kore")).toBe(true); - expect(voices?.some((voice) => voice.id === "Puck" && voice.name === "Puck")).toBe(true); + const voiceLabels = voices?.map((voice) => `${voice.id}:${voice.name}`); + expect(voiceLabels).toContain("Kore:Kore"); + expect(voiceLabels).toContain("Puck:Puck"); }); it("formats Google TTS HTTP errors with provider details", async () => { diff --git a/extensions/openai/realtime-voice-provider.test.ts b/extensions/openai/realtime-voice-provider.test.ts index fc02eb7a962..ad3704777ca 100644 --- a/extensions/openai/realtime-voice-provider.test.ts +++ b/extensions/openai/realtime-voice-provider.test.ts @@ -1496,7 +1496,7 @@ describe("buildOpenAIRealtimeVoiceProvider", () => { socket.emit("message", Buffer.from(JSON.stringify({ type: "response.done" }))); expect(onError).not.toHaveBeenCalled(); - expect(parseSent(socket).some((event) => event.type === "response.create")).toBe(false); + expect(parseSent(socket).filter((event) => event.type === "response.create")).toEqual([]); bridge.submitToolResult("call_1", { text: "done" }); diff --git a/extensions/skill-workshop/index.test.ts b/extensions/skill-workshop/index.test.ts index 55331d5cf0e..c075bd2849e 100644 --- a/extensions/skill-workshop/index.test.ts +++ b/extensions/skill-workshop/index.test.ts @@ -983,7 +983,7 @@ describe("skill-workshop", () => { const proposal = details.proposal as SkillProposal | undefined; expect(proposal?.status).toBe("quarantined"); expect(proposal?.quarantineReason).toContain("prompt"); - expect(proposal?.scanFindings?.some((finding) => finding.severity === "critical")).toBe(true); + expect(proposal?.scanFindings?.map((finding) => finding.severity)).toContain("critical"); const store = new SkillWorkshopStore({ stateDir, workspaceDir }); expect(await store.list("quarantined")).toHaveLength(1); }); diff --git a/extensions/voice-call/index.test.ts b/extensions/voice-call/index.test.ts index f16dca9d0f2..304e9384e15 100644 --- a/extensions/voice-call/index.test.ts +++ b/extensions/voice-call/index.test.ts @@ -174,7 +174,7 @@ function firstRuntimeConfig(): VoiceCallRuntime["config"] | undefined { } function expectWarningIncludes(text: string): void { - expect(noopLogger.warn.mock.calls.some(([message]) => String(message).includes(text))).toBe(true); + expect(noopLogger.warn.mock.calls.map(([message]) => String(message)).join("\n")).toContain(text); } async function registerVoiceCallCli(