From 52474c2d300d6f0addbd111f552353afe3c2710c Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 8 May 2026 12:18:13 +0100 Subject: [PATCH] test: clarify live assertion lists --- extensions/microsoft/microsoft.live.test.ts | 2 +- extensions/ollama/ollama.live.test.ts | 2 +- src/gateway/gateway-codex-harness.live.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/microsoft/microsoft.live.test.ts b/extensions/microsoft/microsoft.live.test.ts index 48c6c5e02f6..8bef656d11b 100644 --- a/extensions/microsoft/microsoft.live.test.ts +++ b/extensions/microsoft/microsoft.live.test.ts @@ -9,6 +9,6 @@ describeLive("microsoft plugin live", () => { const voices = await listMicrosoftVoices(); expect(voices.length).toBeGreaterThan(100); - expect(voices.some((voice) => voice.id === "en-US-MichelleNeural")).toBe(true); + expect(voices.map((voice) => voice.id)).toContain("en-US-MichelleNeural"); }, 60_000); }); diff --git a/extensions/ollama/ollama.live.test.ts b/extensions/ollama/ollama.live.test.ts index 9c2e9eb1179..3a769c95d40 100644 --- a/extensions/ollama/ollama.live.test.ts +++ b/extensions/ollama/ollama.live.test.ts @@ -213,7 +213,7 @@ describe.skipIf(!LIVE)("ollama live", () => { const error = events.find((event) => (event as { type?: string }).type === "error"); expect(error).toBeUndefined(); - expect(events.some((event) => (event as { type?: string }).type === "done")).toBe(true); + expect(events.map((event) => (event as { type?: string }).type)).toContain("done"); expect(payload?.model).toBe(CHAT_MODEL); expect(payload?.options?.num_ctx).toBe(4096); expect(payload?.options?.top_p).toBe(0.9); diff --git a/src/gateway/gateway-codex-harness.live.test.ts b/src/gateway/gateway-codex-harness.live.test.ts index fa5a78ffa47..79436798fe2 100644 --- a/src/gateway/gateway-codex-harness.live.test.ts +++ b/src/gateway/gateway-codex-harness.live.test.ts @@ -364,7 +364,7 @@ async function verifyCodexImageProbe(params: { } const { extractPayloadText } = await import("./test-helpers.agent-results.js"); expect(extractPayloadText(payload.result)).toContain(expectedToken); - expect(events.some((event) => event.stream === "codex_app_server.lifecycle")).toBe(true); + expect(events.map((event) => event.stream)).toContain("codex_app_server.lifecycle"); } function findGuardianReviewStatus(events: CapturedAgentEvent[]): "approved" | "denied" | undefined {