From 3d9d474c0dfbfbba2c49225abfd7f06c00a519b2 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 12 May 2026 00:59:00 +0100 Subject: [PATCH] test: guard browser cdp mock calls --- extensions/browser/src/browser/cdp.helpers.test.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/extensions/browser/src/browser/cdp.helpers.test.ts b/extensions/browser/src/browser/cdp.helpers.test.ts index c907bae950d..9462ead6e66 100644 --- a/extensions/browser/src/browser/cdp.helpers.test.ts +++ b/extensions/browser/src/browser/cdp.helpers.test.ts @@ -26,6 +26,15 @@ describe("cdp helpers", () => { fetchWithSsrFGuardMock.mockReset(); }); + function requireGuardedFetchRequest() { + const [call] = fetchWithSsrFGuardMock.mock.calls; + if (!call) { + throw new Error("expected guarded CDP fetch call"); + } + const [request] = call; + return request; + } + it("releases guarded CDP fetches after the response body is consumed", async () => { const release = vi.fn(async () => {}); const json = vi.fn(async () => { @@ -105,7 +114,7 @@ describe("cdp helpers", () => { }), ).resolves.toBeUndefined(); - const [request] = fetchWithSsrFGuardMock.mock.calls[0] ?? []; + const request = requireGuardedFetchRequest(); expect(request?.url).toBe("http://127.0.0.1:9222/json/version"); expect(request?.policy).toEqual({ dangerouslyAllowPrivateNetwork: false, @@ -131,7 +140,7 @@ describe("cdp helpers", () => { }), ).resolves.toBeUndefined(); - const [request] = fetchWithSsrFGuardMock.mock.calls[0] ?? []; + const request = requireGuardedFetchRequest(); expect(request?.url).toBe("http://127.0.0.1:9222/json/version"); expect(request?.policy).toEqual({ dangerouslyAllowPrivateNetwork: false,