From 3c9fbf7071d4a1dec07f90c41f58539e1ed2f303 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Mon, 11 May 2026 20:24:29 +0100
Subject: [PATCH] test: guard ui tooling assertions

---
 test/scripts/docker-e2e-plan.test.ts                 | 11 +++++++----
 .../ui/app-settings.refresh-active-tab.node.test.ts  | 12 +++++++-----
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/test/scripts/docker-e2e-plan.test.ts b/test/scripts/docker-e2e-plan.test.ts
index 3c3f17fcf4a..27139bd7844 100644
--- a/test/scripts/docker-e2e-plan.test.ts
+++ b/test/scripts/docker-e2e-plan.test.ts
@@ -818,10 +818,13 @@ describe("scripts/lib/docker-e2e-plan", () => {
       ),
     );
     expect(plan.lanes).toHaveLength(BUNDLED_PLUGIN_INSTALL_UNINSTALL_SHARDS);
-    expect(plan.lanes.at(0)).toBeDefined();
-    expect(plan.lanes.at(23)).toBeDefined();
-    expect(summarizeLane(plan.lanes[0])).toEqual(bundledPluginSweepLane(0));
-    expect(summarizeLane(plan.lanes[23])).toEqual(bundledPluginSweepLane(23));
+    const firstLane = plan.lanes[0];
+    const lastLane = plan.lanes[23];
+    if (!firstLane || !lastLane) {
+      throw new Error("Expected bundled plugin sweep boundary lanes");
+    }
+    expect(summarizeLane(firstLane)).toEqual(bundledPluginSweepLane(0));
+    expect(summarizeLane(lastLane)).toEqual(bundledPluginSweepLane(23));
     expect(plan.needs).toEqual({
       bareImage: false,
       e2eImage: true,
diff --git a/ui/src/ui/app-settings.refresh-active-tab.node.test.ts b/ui/src/ui/app-settings.refresh-active-tab.node.test.ts
index 794408a9d7c..eed494d8ed3 100644
--- a/ui/src/ui/app-settings.refresh-active-tab.node.test.ts
+++ b/ui/src/ui/app-settings.refresh-active-tab.node.test.ts
@@ -177,12 +177,14 @@ function expectBufferedPerformanceEvent(
       return candidate.payload?.[key] === expected;
     });
   });
-  expect(entry).toBeDefined();
-  for (const [key, expected] of Object.entries(expectedPayload)) {
-    expect(entry?.payload?.[key]).toBe(expected);
+  if (!entry) {
+    throw new Error(`Expected performance event ${event}`);
   }
-  expect(entry?.payload?.durationMs).toBeTypeOf("number");
-  return entry?.payload;
+  for (const [key, expected] of Object.entries(expectedPayload)) {
+    expect(entry.payload?.[key]).toBe(expected);
+  }
+  expect(entry.payload?.durationMs).toBeTypeOf("number");
+  return entry.payload;
 }
 
 describe("refreshActiveTab", () => {