From 384a5e35ef6f040aac1206121bf69f3fb12ff0b4 Mon Sep 17 00:00:00 2001 From: Felarof Date: Fri, 2 Jan 2026 11:16:13 -0800 Subject: [PATCH] fix: remove checkbox in LLM chat and hub page -- dead code --- .../options/llm-hub/HubProviderRow.tsx | 61 ++----------------- .../options/llm-hub/HubProvidersList.tsx | 6 -- .../options/llm-hub/LlmHubPage.tsx | 12 +--- apps/agent/lib/browseros/prefs.ts | 1 - apps/agent/lib/llm-hub/storage.ts | 33 ++++------ apps/agent/lib/llm-hub/useLlmHubProviders.ts | 46 +++----------- bun.lock | 3 + lefthook.yml | 8 +-- packages/shared/package.json | 3 + 9 files changed, 36 insertions(+), 137 deletions(-) diff --git a/apps/agent/entrypoints/options/llm-hub/HubProviderRow.tsx b/apps/agent/entrypoints/options/llm-hub/HubProviderRow.tsx index 89197d3f..cfc6af8b 100644 --- a/apps/agent/entrypoints/options/llm-hub/HubProviderRow.tsx +++ b/apps/agent/entrypoints/options/llm-hub/HubProviderRow.tsx @@ -1,65 +1,26 @@ -import { Check, Globe2, Trash2 } from 'lucide-react' -import type { FC, KeyboardEvent } from 'react' +import { Globe2, Trash2 } from 'lucide-react' +import type { FC } from 'react' import { useMemo } from 'react' import { Button } from '@/components/ui/button' -import { cn } from '@/lib/utils' import { getFaviconUrl, type LlmHubProvider } from './models' interface HubProviderRowProps { provider: LlmHubProvider - isSelected: boolean canDelete: boolean - onSelect: () => void onEdit: () => void onDelete: () => void } export const HubProviderRow: FC = ({ provider, - isSelected, canDelete, - onSelect, onEdit, onDelete, }) => { const iconUrl = useMemo(() => getFaviconUrl(provider.url), [provider.url]) - const handleRowClick = () => { - if (!isSelected) { - onSelect() - } - } - - const handleRowKeyDown = (event: KeyboardEvent) => { - if (event.key === 'Enter' || event.key === ' ') { - event.preventDefault() - handleRowClick() - } - } - return ( - - + ) } diff --git a/apps/agent/entrypoints/options/llm-hub/HubProvidersList.tsx b/apps/agent/entrypoints/options/llm-hub/HubProvidersList.tsx index 845a084d..1a785639 100644 --- a/apps/agent/entrypoints/options/llm-hub/HubProvidersList.tsx +++ b/apps/agent/entrypoints/options/llm-hub/HubProvidersList.tsx @@ -6,9 +6,7 @@ import type { LlmHubProvider } from './models' interface HubProvidersListProps { providers: LlmHubProvider[] - selectedIndex: number isLoading?: boolean - onSelectProvider: (index: number) => void onEditProvider: (index: number) => void onDeleteProvider: (index: number) => void onAddProvider: () => void @@ -16,9 +14,7 @@ interface HubProvidersListProps { export const HubProvidersList: FC = ({ providers, - selectedIndex, isLoading = false, - onSelectProvider, onEditProvider, onDeleteProvider, onAddProvider, @@ -77,9 +73,7 @@ export const HubProvidersList: FC = ({ 1} - onSelect={() => onSelectProvider(index)} onEdit={() => onEditProvider(index)} onDelete={() => onDeleteProvider(index)} /> diff --git a/apps/agent/entrypoints/options/llm-hub/LlmHubPage.tsx b/apps/agent/entrypoints/options/llm-hub/LlmHubPage.tsx index c5f5af01..a709d734 100644 --- a/apps/agent/entrypoints/options/llm-hub/LlmHubPage.tsx +++ b/apps/agent/entrypoints/options/llm-hub/LlmHubPage.tsx @@ -17,14 +17,8 @@ import { LlmHubHeader } from './LlmHubHeader' /** @public */ export const LlmHubPage: FC = () => { - const { - providers, - selectedIndex, - isLoading, - saveProvider, - setSelectedIndex, - deleteProvider, - } = useLlmHubProviders() + const { providers, isLoading, saveProvider, deleteProvider } = + useLlmHubProviders() const [isAddDialogOpen, setIsAddDialogOpen] = useState(false) const [editingIndex, setEditingIndex] = useState(null) @@ -64,9 +58,7 @@ export const LlmHubPage: FC = () => { { +export async function loadProviders(): Promise { try { const adapter = getBrowserOSAdapter() - - const [providersPref, selectedPref] = await Promise.all([ - adapter.getPref(BROWSEROS_PREFS.THIRD_PARTY_LLM_PROVIDERS), - adapter.getPref(BROWSEROS_PREFS.THIRD_PARTY_LLM_SELECTED), - ]) - + const providersPref = await adapter.getPref( + BROWSEROS_PREFS.THIRD_PARTY_LLM_PROVIDERS, + ) const providers = (providersPref?.value as LlmHubProvider[]) || [] - const selectedIndex = (selectedPref?.value as number) || 0 if (providers.length === 0) { - return { providers: DEFAULT_PROVIDERS, selectedIndex: 0 } + return DEFAULT_PROVIDERS } - return { providers, selectedIndex } + return providers } catch { - return { providers: DEFAULT_PROVIDERS, selectedIndex: 0 } + return DEFAULT_PROVIDERS } } export async function saveProviders( providers: LlmHubProvider[], - selectedIndex: number, ): Promise { try { const adapter = getBrowserOSAdapter() - - const [providersSuccess, selectedSuccess] = await Promise.all([ - adapter.setPref(BROWSEROS_PREFS.THIRD_PARTY_LLM_PROVIDERS, providers), - adapter.setPref(BROWSEROS_PREFS.THIRD_PARTY_LLM_SELECTED, selectedIndex), - ]) - - return providersSuccess && selectedSuccess + return await adapter.setPref( + BROWSEROS_PREFS.THIRD_PARTY_LLM_PROVIDERS, + providers, + ) } catch { return false } diff --git a/apps/agent/lib/llm-hub/useLlmHubProviders.ts b/apps/agent/lib/llm-hub/useLlmHubProviders.ts index 65c0adeb..1ee9d041 100644 --- a/apps/agent/lib/llm-hub/useLlmHubProviders.ts +++ b/apps/agent/lib/llm-hub/useLlmHubProviders.ts @@ -9,17 +9,14 @@ import { /** @public */ export interface UseLlmHubProvidersReturn { providers: LlmHubProvider[] - selectedIndex: number isLoading: boolean saveProvider: (provider: LlmHubProvider, editIndex?: number) => Promise - setSelectedIndex: (index: number) => Promise deleteProvider: (index: number) => Promise } /** @public */ export function useLlmHubProviders(): UseLlmHubProvidersReturn { const [providers, setProviders] = useState([]) - const [selectedIndex, setSelectedIndexState] = useState(0) const [isLoading, setIsLoading] = useState(true) useEffect(() => { @@ -27,11 +24,9 @@ export function useLlmHubProviders(): UseLlmHubProvidersReturn { setIsLoading(true) try { const data = await loadProviders() - setProviders(data.providers) - setSelectedIndexState(data.selectedIndex) + setProviders(data) } catch { setProviders(DEFAULT_PROVIDERS) - setSelectedIndexState(0) } finally { setIsLoading(false) } @@ -49,23 +44,10 @@ export function useLlmHubProviders(): UseLlmHubProvidersReturn { const prev = providers setProviders(updatedProviders) - const success = await saveProviders(updatedProviders, selectedIndex) + const success = await saveProviders(updatedProviders) if (!success) setProviders(prev) }, - [providers, selectedIndex], - ) - - const setSelectedIndex = useCallback( - async (index: number) => { - if (index < 0 || index >= providers.length) return - - const prev = selectedIndex - setSelectedIndexState(index) - - const success = await saveProviders(providers, index) - if (!success) setSelectedIndexState(prev) - }, - [providers, selectedIndex], + [providers], ) const deleteProvider = useCallback( @@ -73,34 +55,20 @@ export function useLlmHubProviders(): UseLlmHubProvidersReturn { if (providers.length <= 1) return const updatedProviders = providers.filter((_, i) => i !== index) - let newSelectedIndex = selectedIndex - if (selectedIndex === index) { - newSelectedIndex = 0 - } else if (selectedIndex > index) { - newSelectedIndex = selectedIndex - 1 - } - - const prevProviders = providers - const prevSelected = selectedIndex + const prev = providers setProviders(updatedProviders) - setSelectedIndexState(newSelectedIndex) - const success = await saveProviders(updatedProviders, newSelectedIndex) - if (!success) { - setProviders(prevProviders) - setSelectedIndexState(prevSelected) - } + const success = await saveProviders(updatedProviders) + if (!success) setProviders(prev) }, - [providers, selectedIndex], + [providers], ) return { providers, - selectedIndex, isLoading, saveProvider, - setSelectedIndex, deleteProvider, } } diff --git a/bun.lock b/bun.lock index 14b3f54a..d8df68d4 100644 --- a/bun.lock +++ b/bun.lock @@ -172,6 +172,9 @@ "packages/shared": { "name": "@browseros/shared", "version": "0.0.1", + "dependencies": { + "zod": "^3.24.2", + }, }, }, "trustedDependencies": [ diff --git a/lefthook.yml b/lefthook.yml index afd9bd1c..4eef46eb 100644 --- a/lefthook.yml +++ b/lefthook.yml @@ -16,10 +16,10 @@ commit-msg: pre-commit: commands: - check: - glob: "*.{js,ts,cjs,mjs,d.cts,d.mts,jsx,tsx,json,jsonc}" - run: npx @biomejs/biome check --write --no-errors-on-unmatched --files-ignore-unknown=true --colors=off {staged_files} - stage_fixed: true + # check: + # glob: "*.{js,ts,cjs,mjs,d.cts,d.mts,jsx,tsx,json,jsonc}" + # run: ./node_modules/.bin/biome check --write --no-errors-on-unmatched --files-ignore-unknown=true --colors=off {staged_files} + # stage_fixed: true file-length: glob: "*.{ts,tsx}" diff --git a/packages/shared/package.json b/packages/shared/package.json index 1aa68e47..bb3ceb87 100644 --- a/packages/shared/package.json +++ b/packages/shared/package.json @@ -5,6 +5,9 @@ "scripts": { "typecheck": "tsc --noEmit" }, + "dependencies": { + "zod": "^3.24.2" + }, "exports": { "./constants/ports": { "types": "./src/constants/ports.ts",