LLM/BrowserOS
1
0
Fork 0
mirror of https://github.com/browseros-ai/BrowserOS.git synced 2026-05-21 12:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use pageIds instead of tabIds in tab group tests (#397)

Browse Source 
Tests were passing raw Chrome tabIds to group_tabs and ungroup_tabs tools,
but the Zod schemas expect pageIds (MCP-layer page IDs). The tabIds field
was silently stripped during validation, causing both tests to fail.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Nikhil
2026-03-03 10:54:49 -08:00
committed by GitHub
parent 14ab8fe97e
commit 20bb4cb21e
1 changed files with 6 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
apps/server/tests/tools/tab-groups.test.ts
View File

@@ -1,6 +1,6 @@
import { describe, it } from 'bun:test' import { describe, it } from 'bun:test'
import assert from 'node:assert' import assert from 'node:assert'
import { close_page, list_pages, new_page } from '../../src/tools/navigation' import { close_page, new_page } from '../../src/tools/navigation'
import { import {
close_tab_group, close_tab_group,
group_tabs, group_tabs,
@@ -40,22 +40,11 @@ describe('tab group tools', () => {
textOf(tab2Result).match(/Page ID:\s*(\d+)/)?.[1], textOf(tab2Result).match(/Page ID:\s*(\d+)/)?.[1],
) )
// Get tab IDs from list_pages const pageIds = [tab1PageId, tab2PageId]
const pagesResult = await execute(list_pages, {})
const pagesText = textOf(pagesResult)
// Extract tab IDs for our pages
const tabIds: number[] = []
for (const pageId of [tab1PageId, tab2PageId]) {
const pageRegex = new RegExp(`${pageId}\\.\\s+.*?\\(tab\\s+(\\d+)\\)`)
const match = pagesText.match(pageRegex)
if (match) tabIds.push(Number(match[1]))
}
assert.ok(tabIds.length === 2, `Expected 2 tab IDs, got ${tabIds.length}`)
// Group tabs // Group tabs
const groupResult = await execute(group_tabs, { const groupResult = await execute(group_tabs, {
tabIds, pageIds,
title: 'Test Group', title: 'Test Group',
}) })
assert.ok(!groupResult.isError, textOf(groupResult)) assert.ok(!groupResult.isError, textOf(groupResult))
@@ -80,7 +69,7 @@ describe('tab group tools', () => {
assert.ok(textOf(listResult).includes('Renamed Group')) assert.ok(textOf(listResult).includes('Renamed Group'))
// Ungroup // Ungroup
const ungroupResult = await execute(ungroup_tabs, { tabIds }) const ungroupResult = await execute(ungroup_tabs, { pageIds })
assert.ok(!ungroupResult.isError, textOf(ungroupResult)) assert.ok(!ungroupResult.isError, textOf(ungroupResult))
assert.ok(textOf(ungroupResult).includes('Ungrouped')) assert.ok(textOf(ungroupResult).includes('Ungrouped'))
@@ -95,18 +84,12 @@ describe('tab group tools', () => {
const tabResult = await execute(new_page, { url: 'about:blank' }) const tabResult = await execute(new_page, { url: 'about:blank' })
const tabPageId = Number(textOf(tabResult).match(/Page ID:\s*(\d+)/)?.[1]) const tabPageId = Number(textOf(tabResult).match(/Page ID:\s*(\d+)/)?.[1])
// Get tab ID
const pagesResult = await execute(list_pages, {})
const pageRegex = new RegExp(`${tabPageId}\\.\\s+.*?\\(tab\\s+(\\d+)\\)`)
const tabMatch = textOf(pagesResult).match(pageRegex)
assert.ok(tabMatch, 'Could not find tab ID')
const tabId = Number(tabMatch?.[1])
// Group // Group
const groupResult = await execute(group_tabs, { const groupResult = await execute(group_tabs, {
tabIds: [tabId], pageIds: [tabPageId],
title: 'Disposable', title: 'Disposable',
}) })
assert.ok(!groupResult.isError, textOf(groupResult))
const groupId = textOf(groupResult).match(/Group ID:\s*(\S+)/)?.[1] const groupId = textOf(groupResult).match(/Group ID:\s*(\S+)/)?.[1]
// Close group (also closes the tab) // Close group (also closes the tab)